Skip to content

Validate combined scroll state and delta handling - #38

Closed
KulmanD wants to merge 10 commits into
mainfrom
perf/scroll-processing-integration
Closed

Validate combined scroll state and delta handling#38
KulmanD wants to merge 10 commits into
mainfrom
perf/scroll-processing-integration

Conversation

@KulmanD

@KulmanD KulmanD commented Jul 26, 2026

Copy link
Copy Markdown
Owner

What changed

Why

Both accepted candidates modify the same scroll callback. This branch proves their code and state transitions coexist before either runtime change is promoted.

Validation

  • swift build
  • swift build -c release
  • GitHub Actions: 43 tests, 0 failures
  • shell syntax checks
  • source sharing archive excludes tests and scripts/performance/
  • no XCTest/Testing linkage
  • no timers, background threads, retained event history, or reposted scroll events
  • measurement-runner smoke test stopped the worker and preserved user config

Performance and remaining checks

The combined helper is 433624 bytes, 1072 bytes over baseline and 48 bytes above the sum of the isolated deltas. Long repeated idle, combined fixed-event active cost, and physical MX Master/trackpad checks are deliberately deferred to the maintainer using:

bash scripts/performance/measure-candidate.sh --label scroll-processing-integration

This PR remains draft and must not merge until those deferred interaction gates are recorded. Related: #24, #25.

KulmanD commented Jul 26, 2026

Copy link
Copy Markdown
Owner Author

Superseded by draft PR #40, which contains this change, its performance evidence, the complete accepted integration, and passing final CI. Closing this draft without merging avoids duplicate commits. The branch is intentionally retained for isolated comparison and deferred measurements.

@KulmanD KulmanD closed this Jul 26, 2026
@KulmanD
KulmanD deleted the perf/scroll-processing-integration branch July 27, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant